This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add WebP support to psammead-image component #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
changed the title
jroebu14
commented
Dec 10, 2021
There was a problem hiding this comment.
Nice 👏
Even though you did 99% of the work @amoore108 GitHub won't let me approve because I'm the author of the PR. Has my approval anyway 🙂
Haha no worries! Thanks for the pairing at the start, most of the changes I did were just test fixes. I'll approve it on my end. |
amoore108
approved these changes
Dec 10, 2021
ryanmccombe
reviewed
Dec 13, 2021
| @@ -19,13 +29,15 @@ AmpImg.propTypes = { | |||
| sizes: string, | |||
| src: string.isRequired, | |||
| srcset: string, | |||
| fallbackSrcset: string, | |||
There was a problem hiding this comment.
new prop may warrant a doc update to readme.md
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of bbc/simorgh#9628
Overall change:
psammead-imagecomponent to use a<picture>element with 2 sources. 1 for WebP srcsets and 1 fallback srcset for JPG/PNG.psammead-imageandpsammead-media-playermajor versionsCode changes:
<picture>tag to thepsammead-imagecomponent<amp-img fallback.../>nested component to handle image format fallback in AMPfallbackSrcsetprop